[DMS-197] [DMS-291] Enabling and Fixing E2E Tests #199
Conversation
Test Results431 tests +40 402 ✅ +30 2m 16s ⏱️ +9s Results for commit d2ba0ee. ± Comparison against base commit f8e9b66. This pull request removes 44 and adds 84 tests. Note that renamed tests count towards both.This pull request removes 12 skipped tests and adds 23 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
… that was unique has been merged into CreateResourcesValidation.feature.
Updated descriptions Ticket numbers for ignored tests
| Scenario: 01 GET / returns the root Discovery API document | ||
| Given a GET to the root of the API | ||
| When a GET request is made to "/" |
There was a problem hiding this comment.
I should have noticed in my prior peer review that this was mixing up Given and When.
There was a problem hiding this comment.
I remember this, and the reason of the Given a GET to the root of the API was because we have it in that way in the Information.feature file
Feature: Information
Retrieve information about the API
Scenario: 01 Load information
Given a get to the root of the API
Then retrieves the information about the API
But I think is better to keep the When a GET request is made to "/"
There was a problem hiding this comment.
Also, I was being a little bit lazy that I didn't want to write a new step definition 😆
| Then it should respond with 200 | ||
| And the response body is | ||
| """ | ||
| { | ||
| "version": "1.0.0", | ||
| "applicationName": "Ed-Fi Alliance Data Management Service" | ||
| "applicationName": "Ed-Fi Alliance Data Management Service", |
There was a problem hiding this comment.
This JSON was invalid.
There was a problem hiding this comment.
Covered by the new DiscoveryAPI.feature.
There was a problem hiding this comment.
This had overposting, which is also covered in the ResourceCreate and ResourceUpdate features.
| @@ -1,35 +1,47 @@ | |||
| Feature: Validation of DELETE requests that would cause a foreign key violation | |||
|
|
|||
| Background: | |||
| Given this School Year exists | |||
There was a problem hiding this comment.
We did not have a step definition that could use this syntax.
| "currentSchoolYear": false, | ||
| "schoolYearDescription": "2021-2022" | ||
| } | ||
| """ |
There was a problem hiding this comment.
This was an interesting little challenge. On the back-end when we want to inject an id value to replace {id}, we only had access to the last id value created in the background section above. Which probably isn't the one we need here. To get around this, I just reposted the document for the item to delete - so that the desired document's id value is the last one recorded before running the When statement.
There was a problem hiding this comment.
I think Suganya had this issue before ~2 weeks ago, but I can't tag her. Probably this could be useful for her. Thanks
There was a problem hiding this comment.
@CSR2017 see above.
There was a problem hiding this comment.
It was set up to generate the necessary Given steps and add the word references for which we should remove.
Scenario: 01 Ensure clients cannot delete a year that is used by another item
Given the system has these "schoolYearTypes" references
| schoolYear | currentSchoolYear | schoolYearDescription |
| 2022 | false | 2021-2022 |
And the system has these "calendars"
| calendarCode | schoolReference | schoolYearTypeReference | calendarTypeDescriptor |
| "2010605675" | {"schoolId":255901107} | {"schoolYear":2022} | uri://ed-fi.org/CalendarTypeDescriptor#Student Specific |
When a DELETE request is made to referenced resource "/ed-fi/schoolYearTypes/{id}"
Then it should respond with 409
There was a problem hiding this comment.
@JBrenesSimpat when you rebase on top of my changes to the "delete" feature file, please feel free to completely overwrite my changes, keeping whatever you have done.
|
|
||
| Scenario: 04 Ensure that clients cannot GET an abstract entity (Student Program Association) | ||
| When a GET request is made to "/ed-fi/generalStudentProgramAssociations" | ||
| Then it should respond with 404 |
There was a problem hiding this comment.
- Enabled the file.
- Moved it to a new directory.
- Removed
@ignore
No other changes to the file.
| | classPeriodName | schoolReference | | ||
| | 01 - Traditional | { "schoolId": 255901001 } | | ||
| | 02 - Traditional | { "schoolId": 255901001 } | | ||
| When a POST request is made to "ed-fi/bellschedules" with | ||
| When a POST request is made to "/ed-fi/bellschedules" with |
There was a problem hiding this comment.
We had a mix of slash and not slash. I standardized on having the leading slash, because I think that works with what we're used to seeing in Open API docs and Swagger UI.
There was a problem hiding this comment.
Consolidated these tests, which were about overposting, into the create and update test files.
There was a problem hiding this comment.
Discovery API feature file replaces this one.
stephenfuqua
changed the title
| @@ -45,7 +45,7 @@ internal async Task GetMetadata(HttpContext httpContext) | |||
| { | |||
| dependencies = $"{baseUrl}/dependencies", | |||
| specifications = $"{baseUrl}/specifications", | |||
| xsdFiles = $"{baseUrl}/xsdMetadata" | |||
| xsdMetadata = $"{baseUrl}/xsd" | |||
There was a problem hiding this comment.
This is the format I had previously defined in the Discovery API standard. I was able to find this error thanks to @elopezgap's review of the API standard documents.
| Given the system has these "Schools" | ||
| | schoolId | nameOfInstitution | educationOrganizationCategories | gradeLevels | | ||
| | 100 | School Test | [{ "educationOrganizationCategoryDescriptor": "uri://tpdm.ed-fi.org/EducationOrganizationCategoryDescriptor#School"}] | [ {"gradeLevelDescriptor": "uri://ed-fi.org/GradeLevelDescriptor#Ninth grade"}] | | ||
| And a POST request is made to "courses" with |
There was a problem hiding this comment.
Do we need the leading slash /courses ?
There was a problem hiding this comment.
Technically no, but it should be failing since it does not have ed-fi/. Unfortunately, the mistake in line 66 results in a 404 - which is exactly what this test is looking for! A false positive.
No description provided.