[DMS-279] New ODS/API 7.2 error message format for key unification #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBrenesSimpat
commented
Jul 19, 2024
| responseJson.Should().BeEquivalentTo(expectedBodyJson, options => options | ||
| .WithoutStrictOrdering() | ||
| .IgnoringCyclicReferences() | ||
| .RespectingRuntimeTypes() |
There was a problem hiding this comment.
Testing I found that it always gave the evaluation of the expected result as a false positive, I found that adding .RespectingRuntimeTypes() solves the problem.
simpat-adam
requested changes
Jul 23, 2024
| .Select(x => $"'{x}'") | ||
| .ToArray() | ||
| ); | ||
| var targetSegment = targetPath.Segments[1].ToString().Replace(".", ""); |
There was a problem hiding this comment.
I don't know that this will always be the proper way to get the property name you're looking for. It looks like you're assuming a path like {$.schoolReference.schoolId} and extracting schoolId. Instead of hard coding the segment at index 1, it might be safer to take the segment at the last index. Also instead of .Replace I would suggest either TrimStart or [1..]
simpat-adam
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.