Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DMS-238] Automatically run integration tests on pull request #195

Merged
merged 9 commits into from
Jul 18, 2024

Conversation

JBrenesSimpat
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jul 17, 2024

Test Results

384 tests  +179   365 ✅ +160   2m 18s ⏱️ + 2m 16s
  5 suites +  2    19 💤 + 19 
  5 files   +  2     0 ❌ ±  0 

Results for commit 659ff76. ± Comparison against base commit d6c34df.

♻️ This comment has been updated with latest results.

shell: pwsh
services:
postgres:
image: postgres:14.12
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is included, I don't think you needed to add this services section. This section starts a Docker image running PostgreSQL.

To start the service directly inside the runner, instead of in another container, I think you just need to run sudo systemctl start postgresql.service.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, I think you have to configure it yourself in that case. Stack Overflow example. What you have already done is working fine, so let's keep it. However, in that case, let's update the PostgreSQL version to the same one used in our Kubernetes setup: postgres:16.3-alpine3.20@sha256:e89da2c083a5405943408b6807cd1fd25dc9010c1294e30611b841778bedc653

@JBrenesSimpat JBrenesSimpat marked this pull request as ready for review July 17, 2024 21:23
@JBrenesSimpat JBrenesSimpat requested a review from a team as a code owner July 17, 2024 21:23
@msilesgap
Copy link
Contributor

On this file docs/RUNNING-LOCALLY.md there is a section called Running the EdFi.DataManagementService.Api.Tests.Integration, could you check if the documentation needs to be updated.

@stephenfuqua stephenfuqua merged commit b06d2a7 into main Jul 18, 2024
12 checks passed
@stephenfuqua stephenfuqua deleted the DMS-238 branch July 18, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants