-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DMS-238] Automatically run integration tests on pull request #195
Conversation
.github/workflows/on-pullrequest.yml
Outdated
shell: pwsh | ||
services: | ||
postgres: | ||
image: postgres:14.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the version that is included with ubuntu https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#postgresql
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is included, I don't think you needed to add this services
section. This section starts a Docker image running PostgreSQL.
To start the service directly inside the runner, instead of in another container, I think you just need to run sudo systemctl start postgresql.service
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, I think you have to configure it yourself in that case. Stack Overflow example. What you have already done is working fine, so let's keep it. However, in that case, let's update the PostgreSQL version to the same one used in our Kubernetes setup: postgres:16.3-alpine3.20@sha256:e89da2c083a5405943408b6807cd1fd25dc9010c1294e30611b841778bedc653
On this file docs/RUNNING-LOCALLY.md there is a section called |
No description provided.