Skip to content

Commit

Permalink
Style update and an missed ignore
Browse files Browse the repository at this point in the history
  • Loading branch information
@stephenfuqua
stephenfuqua committed Jul 23, 2024
1 parent 48cb842 commit 6c190a1
Show file tree
Hide file tree
Showing 2 changed files with 49 additions and 62 deletions.
54 changes: 27 additions & 27 deletions ...s/EdFi.DataManagementService.Tests.E2E/Features/Resources/ReadResourcesValidation.feature
View file
Original file line number Diff line number Diff line change
Expand Up @@ -61,37 +61,37 @@ Feature: Resources "Read" Operation validations

Scenario: 05 Verify response code 404 when trying to get a school with an ID that corresponds to Course
Given the system has these "Schools"
| schoolId | nameOfInstitution | educationOrganizationCategories | gradeLevels |
| 100 | School Test | [{ "educationOrganizationCategoryDescriptor": "uri://tpdm.ed-fi.org/EducationOrganizationCategoryDescriptor#School"}] | [ {"gradeLevelDescriptor": "uri://ed-fi.org/GradeLevelDescriptor#Ninth grade"}] |
And a POST request is made to "courses" with
"""
{
"courseCode": "ALG-2",
"identificationCodes": [
{
"courseIdentificationSystemDescriptor": "uri://ed-fi.org/CourseIdentificationSystemDescriptor#LEA course code",
"identificationCode": "ALG-2"
}
],
"educationOrganizationReference": {
"educationOrganizationId": 100
},
"courseTitle": "Algebra 2",
"numberOfParts": 2
}
"""
| schoolId | nameOfInstitution | educationOrganizationCategories | gradeLevels |
| 100 | School Test | [{ "educationOrganizationCategoryDescriptor": "uri://tpdm.ed-fi.org/EducationOrganizationCategoryDescriptor#School"}] | [ {"gradeLevelDescriptor": "uri://ed-fi.org/GradeLevelDescriptor#Ninth grade"}] |
And a POST request is made to "courses" with
"""
{
"courseCode": "ALG-2",
"identificationCodes": [
{
"courseIdentificationSystemDescriptor": "uri://ed-fi.org/CourseIdentificationSystemDescriptor#LEA course code",
"identificationCode": "ALG-2"
}
],
"educationOrganizationReference": {
"educationOrganizationId": 100
},
"courseTitle": "Algebra 2",
"numberOfParts": 2
}
"""
When a GET request is made to "/ed-fi/schools/{id}"
Then it should respond with 404

Scenario: 06 Verify response code 200 when trying to get a student with a correct ID
Given a POST request is made to "/ed-fi/students" with
"""
{
"studentUniqueId":"604834",
"birthDate":"2000-01-01",
"firstName":"Thomas",
"lastSurname":"Johnson"
}
"""
"""
{
"studentUniqueId": "604834",
"birthDate": "2000-01-01",
"firstName": "Thomas",
"lastSurname": "Johnson"
}
"""
When a GET request is made to "/ed-fi/students/{id}"
Then it should respond with 200
57 changes: 22 additions & 35 deletions ...EdFi.DataManagementService.Tests.E2E/Features/Resources/UpdateResourcesValidation.feature
View file
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ Feature: Resources "Update" Operation validations
"""

# Descriptors are not validating properly. DMS-295
#@ignore
@ignore
Scenario: 03 Update a document with a string that is too long (Descriptor)
When a PUT request is made to "/ed-fi/absenceEventCategoryDescriptors/{id}" with
"""
Expand Down Expand Up @@ -321,26 +321,15 @@ Feature: Resources "Update" Operation validations
And the response body is
"""
{
"detail": "Data validation failed. See 'validationErrors' for details.",
"type": "urn:ed-fi:api:bad-request:data",
"title": "Data Validation Failed",
"validationErrors": {},
"errors": [
"A non-empty request body is required."
],
"detail": "The request could not be processed. See 'errors' for details.",
"type": "urn:ed-fi:api:bad-request",
"title": "Bad Request",
"status": 400,
"correlationId": null,
"validationErrors": {
"$.namespace": [
"namespace is required."
],
"$.codeValue": [
"codeValue is required."
],
"$.shortDescription": [
"shortDescription is required."
],
"$.id": [
"id is required."
]
},
"errors": []
"correlationId": null
}
"""

Expand Down Expand Up @@ -644,20 +633,15 @@ Feature: Resources "Update" Operation validations
And the response body is
"""
{
"detail": "Data validation failed. See 'validationErrors' for details.",
"type": "urn:ed-fi:api:bad-request:data",
"title": "Data Validation Failed",
"validationErrors": {},
"errors": [
"A non-empty request body is required."
],
"detail": "The request could not be processed. See 'errors' for details.",
"type": "urn:ed-fi:api:bad-request",
"title": "Bad Request",
"status": 400,
"correlationId": null,
"validationErrors": {
"$.contentIdentifier": [
"contentIdentifier is required."
],
"$.namespace": [
"namespace is required."
]
},
"errors": []
"correlationId": null
}
"""

Expand All @@ -683,6 +667,9 @@ Feature: Resources "Update" Operation validations
],
"$.namespace": [
"namespace is required."
],
"$.id": [
"id is required."
]
},
"errors": []
Expand Down Expand Up @@ -814,8 +801,8 @@ Feature: Resources "Update" Operation validations
"""
{
"validationErrors": {
"$.codeValue": [
"codeValue Value should be at most 50 characters"
"$.publisher": [
"publisher Value should be at most 50 characters"
]
},
"errors": [],
Expand Down

0 comments on commit 6c190a1

Please sign in to comment.