Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Database terms for Maniacs #3371

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

florianessl
Copy link
Member

A few new term fields have been added in the latest version of Maniacs, to provide more customization options for some in-game texts:

  • Experience gained
  • Level Up
  • Items received
  • Skill learned

I would have preferred some template strings similar to the ones found in RPG2KE, but they do the job..

I moved those message texts to "battle_commands" which I then renamed to "game_message_terms". The terms code is all over the place & a lot of refactoring should be done here to make localization less of a hassle.
I'm sure this issue came up before & we could use this PR to do also some housekeeping here. 🤔

Maybe move everything related to in-game terms to its own naming scheme? (terms_battle.cpp, terms_actor.cpp, etc.)

New custom fields for liblcf:

Terms,maniac_item_received_a,f,DBString,0xA1,,0,1,
Terms,maniac_level_up_a,f,DBString,0xA2,,0,1,
Terms,maniac_level_up_b,f,DBString,0xA3,,0,1,
Terms,maniac_level_up_c,f,DBString,0xA4,,0,1,
Terms,maniac_exp_received_a,f,DBString,0xA5,,0,1,
Terms,maniac_skill_learned_a,f,DBString,0xA6,,0,1,

maniac_terms1
maniac_terms2

@github-actions github-actions bot added Android Window/Scenes FileFinder Bitmaps Audio Fonts Building Battle Emscripten WebAssembly/JavaScript port for web browsers 3DS Tests MIDI Messages Settings All about customizable features, storing and applying them Input Input related (gamepads, keyboard mappings, mouse support). For KeyInputProc, add event/interpreter Translation labels Mar 16, 2025
@florianessl
Copy link
Member Author

Oops, it wasn't my intention to push this version, which already merges in some stuff not yet in master. I'll rebase & force-push that later.

Another thing I noticed:
Feature::HasPlaceholders() really only affects messages of the battle scene. Makes sense, because the associated database field is called easyrpg_**battle**_use_rpg2ke_strings, but the way it is described in code doesn't make it immediately obvious.
I stumbled upon this after finally migrating VDCE to 2k3 & then had these broken placeholder Level-Up messages. I had to change it back to use the non-template way of stitching together strings. :/
The level-up messages are actually used inside & outside of the battle, so this is also a bit inconsistent. But just renaming the flag & make it affect all types of placeholder messages could maybe break the text of some games.

@Ghabry Ghabry added Refactor RPG_RT Patches and removed Android Window/Scenes FileFinder Bitmaps Audio Fonts Building Battle Emscripten WebAssembly/JavaScript port for web browsers 3DS Tests MIDI Messages Settings All about customizable features, storing and applying them Input Input related (gamepads, keyboard mappings, mouse support). For KeyInputProc, add event/interpreter Translation labels Mar 16, 2025
@Ghabry Ghabry added this to the 0.8.2 milestone Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants