-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Database terms for Maniacs #3371
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: MackValentine <[email protected]> Co-authored-by: Mauro Junior <[email protected]>
Is now only a single command again that can be configured through an editor plugin.
… message terms there: - Game_Actor::GetLevelUpMessage -> Namespace "ActorMessage" - Game_Actor::GetLearningMessage -> Namespace "ActorMessage" - Scene_Battle_* EXP -> Namespace "PartyMessage" - Scene_Battle_* Gold -> Namespace "PartyMessage"
Oops, it wasn't my intention to push this version, which already merges in some stuff not yet in master. I'll rebase & force-push that later. Another thing I noticed: |
A few new term fields have been added in the latest version of Maniacs, to provide more customization options for some in-game texts:
I would have preferred some template strings similar to the ones found in RPG2KE, but they do the job..
I moved those message texts to "battle_commands" which I then renamed to "game_message_terms". The terms code is all over the place & a lot of refactoring should be done here to make localization less of a hassle.
I'm sure this issue came up before & we could use this PR to do also some housekeeping here. 🤔
Maybe move everything related to in-game terms to its own naming scheme? (terms_battle.cpp, terms_actor.cpp, etc.)
New custom fields for liblcf: