Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various cleanup changes #1049

Open
wants to merge 2 commits into
base: pull-request/#1049-Various-cleanup-changes
Choose a base branch
from
Open

Various cleanup changes #1049

wants to merge 2 commits into from

Conversation

rolandreichweinbmw
Copy link
Contributor

This is a collection of different cleanup changes:

  • intrusive_forward_list.h: Remove remove() by pointer because erase() can be used for that
  • algorithm.h: Fix signed distance handling in copy_s and move_s, with added check for order; added test
  • Fix File IDs

@rolandreichweinbmw
Various Cleanup
9e25d54 
Remove remove() by pointer because erase() can be used for that

Fix signed distance handling, with added check for order

Add missing file ID

Fix File IDs

Added test for algorithm.h
@rolandreichweinbmw
Improve types
4ba2a99
@rolandreichweinbmw
Copy link
Contributor Author

rolandreichweinbmw commented Mar 26, 2025 •
edited
Loading

I.e. the (redundant and unnecessary) changes from #1026 are removed here.

@jwellbelove jwellbelove changed the base branch from master to pull-request/#1049-Various-cleanup-changes March 27, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwellbelove jwellbelove jwellbelove left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolandreichweinbmw @jwellbelove