Fix division float over Scalar and float over Array #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthursoprana
requested review from
lincrosenbach,
nicoddemus and
prusse-martin
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 97.43% 97.46% +0.02%
==========================================
Files 53 53
Lines 9174 9214 +40
==========================================
+ Hits 8939 8980 +41
+ Misses 235 234 -1 |
nicoddemus
requested changes
Oct 7, 2019
nicoddemus
requested changes
Oct 7, 2019
lincrosenbach
approved these changes
Oct 7, 2019
arthursoprana
force-pushed
the
fb-BARRIL-15-fix-division
branch
from
2df2799
to
bd775d1
Compare
nicoddemus
requested changes
Oct 8, 2019
arthursoprana
force-pushed
the
fb-BARRIL-15-fix-division
branch
from
9494b47
to
4183039
Compare
arthursoprana
force-pushed
the
fb-BARRIL-15-fix-division
branch
from
f913357
to
69b7798
Compare
nicoddemus
approved these changes
Oct 10, 2019
prusse-martin
approved these changes
Oct 10, 2019
…ision support BARRIL-15
arthursoprana
force-pushed
the
fb-BARRIL-15-fix-division
branch
from
69b7798
to
cf9e39d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to fix the following behavior:
now results in the expected output
I'd say that this PR together with #31 will Fix #15.