Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add correct comparison support for Scalar #31

Closed
wants to merge 7 commits into from
Closed

Add correct comparison support for Scalar #31

wants to merge 7 commits into from

Commits on Oct 14, 2019

  1. Add correct comparison support for Scalar 

    Modified comparison behavior of ``Scalar``. The previous behavior assumes that ``Scalar(1, "m") != Scalar(100, "cm")`` and not it has been changed to ``Scalar(1, "m") == Scalar(100, "cm")``. This may affect users that rely on the previous behavior.

BARRIL-26
    @arthursoprana
    arthursoprana committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    799e745 View commit details
    Browse the repository at this point in the history

  2. Refactored Convert to using combined unit

    @arthursoprana
    arthursoprana committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    721b54d View commit details
    Browse the repository at this point in the history

  3. Add spec file

    @arthursoprana
    arthursoprana committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    30188b1 View commit details
    Browse the repository at this point in the history

  4. Add new tests

    @arthursoprana
    arthursoprana committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    40779a0 View commit details
    Browse the repository at this point in the history

  5. Refactored code, add new tests and avoid getting value from empty sca… 

    …lar passing a unit
    @arthursoprana
    arthursoprana committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    e982896 View commit details
    Browse the repository at this point in the history

  6. Add support for GetValue with unit=="" for empty scalar

    @arthursoprana
    arthursoprana committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    9302300 View commit details
    Browse the repository at this point in the history

  7. Revert behavior

    @arthursoprana
    arthursoprana committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    87f7257 View commit details
    Browse the repository at this point in the history