Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dask graph debug info #2199

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add Dask graph debug info #2199

wants to merge 1 commit into from

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Sep 22, 2023

Description

Some preprocessor functions create Dask graphs that are too large and overwhelm the scheduler.

An example of a pattern that creates this problem is using Python to iterate over many small parts of the input array and combining the result using dask.array.stack.

This pull request adds a debug/warning message containing the graph size and asks users to report the issue if they run into it.

This should help us discover issues like #2179 and SciTools/iris#5455.

Related to #2184


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #2199 (9e77718) into main (09e20d4) will decrease coverage by 0.01%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main    #2199      +/-   ##
==========================================
- Coverage   93.14%   93.13%   -0.01%     
==========================================
  Files         237      237              
  Lines       12829    12836       +7     
==========================================
+ Hits        11949    11955       +6     
- Misses        880      881       +1     
Files Changed Coverage Δ
esmvalcore/preprocessor/_io.py 87.07% <88.88%> (-0.04%) ⬇️

@bouweandela bouweandela added the dask related to improvements using Dask label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dask related to improvements using Dask
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant