[Feature] Implement Move Multiple Items

[catapultam-habeo]

Description

This implements ctrl-click movement of bag contents for ROF+ clients.

Type of change

• New feature (non-breaking change which adds functionality)

Testing

There are three behaviors that are introduced here;

• CTRL + left click -> drops an item into a bag without opening it.
• CTRL + left click -> adds the contents of a bag (on cursor) into another bag without opening it
• CTRL + right click -> swaps the contents of two bags if a bag is on your cursor and you ctrl-right click on another bag.

I don't know how to attach images to demonstrate this.

I would furthermore like some assistance testing this.

Clients tested:

• ROF2

Checklist

• I have tested my changes
• I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
• I have made corresponding changes to the documentation (if applicable, if not delete this line)
• I own the changes of my code and take responsibility for the potential issues that occur

[catapultam-habeo]

Do not merge this. Found some bugs.

[catapultam-habeo]

This isn't working correctly because the cursor bag re-orders itself on SwapItem, causing the transfers subsequent to the first one to fail. I'm not certain how to fix that right now.

No, it is because the swap contains redundant two-way operations.

[catapultam-habeo]

This works according to my testing. It implements all 3 ctrl-click modes exactly replicating client behavior.

1. ctrl + left click single item into bag -> places item into bag without opening it. This will combine stacks as needed, including filling multiple stacks as needed.
2. ctrl + left click bag into bag -> fills target bag with contents of source bag. client checks if there is enough room, etc. This will combine stacks as possible\needed.
3. ctrl + right click bag into bag -> swaps contents of bags. This puts things into lowest ordinal bag slots, but does not combine stacks.

left and right click logic needs to be bifurcated because left click handles things a lot like proper slot swaps or autoinv in terms of stack combining, etc, so we want to leverage the existing logic of SwapItem. right click just bluntly exchanges contents, but we need to respect the new targets instead of just explicitly exchanging the bag contents slot for slot.

[catapultam-habeo]

This has been running on my servers for a while now without issues (~40 users total). I haven't been able to break it personally. I'm reasonably confident in this implementation.

[MazeEQ]

This has been running on my servers for a while now without issues (~40 users total). I haven't been able to break it personally. I'm reasonably confident in this implementation.

Can confirm this has been working as expected.

Have not ran into any issues while testing on Cata's servers.

[catapultam-habeo]

That was a rebase.

[catapultam-habeo]

I'm comfortable with this. I... don't actually know how to make or post videos to demo this in action. It is currently deployed on Retribution.

[Akkadius]

I'm comfortable with this. I... don't actually know how to make or post videos to demo this in action. It is currently deployed on Retribution.

You can use OBS

[catapultam-habeo]

Screencast.from.07-07-2024.10.01.57.PM.webm

[catapultam-habeo]

I found a dupe. Stand by, do not merge.

[catapultam-habeo]

I have corrected the duplication bug. Attached is a video test of all functions.

Screencast.from.07-08-2024.05.17.06.PM.webm

[Akkadius]

I have corrected the duplication bug. Attached is a video test of all functions.

Screencast.from.07-08-2024.05.17.06.PM.webm

Thank you for addressing all of the changes and posting the video. I think this is great you put this feature together.

My only concern (albeit large) was the feedback around item loss and dupes.

If we feel like we are good there - then I'm good.

[catapultam-habeo]

The previous issue was caused by PopItem(...) not sending database updates, so bag swaps could cause additional items to be saved into db in certain circumstances.

I haven't been able to cause any more issues like this; asymmetrical bags, full bags, etc.

[fryguy503]

I pulled this to WFH for live testing, will post any issues I encounter if any.

[Akkadius]

I pulled this to WFH for live testing, will post any issues I encounter if any.

Awesome

[fryguy503]

Been running this for a week and have not noticed any issues related to this PR. Players that use it absolutely love it!

Thank you Cata!