This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix abigen with int expression template arguments #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my contracts, I use several template arguments which are types which resolve to integral values (such as an eosio::name) but are not trivially integer values. This works great in my contracts, but causes abigen to fail. Fix abigen in cases where a template argument is an expression that resolves to an integer, but isn't an integer literal.
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
In my contracts, I use several template arguments which are types
which resolve to integral values (such as an
eosio::name) but arenot trivially integer values. This works great in my contracts, but
causes abigen to fail.
This PR fixes abigen in cases where a template argument is an expression
that resolves to an integer, but isn't an integer literal.
Note: This is targeted at the master branch instead of develop because develop fails to build my contract due to other reasons. I'm hoping that this is just instabilities in unreleased code. In the meantime, I'm staying on 1.8.1, and so I base my PR there.
API Changes
Documentation Additions