This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
EPE-972:Add support for std::tuple in eosio.cdt #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| break; | ||
| return name.substr(0,i+1); | ||
| }; | ||
| kv.name = remove_ending_brackets(name); |
There was a problem hiding this comment.
The statement can be rewritten as
kv.name.assign(name.begin(),
std::find_if_not(name.rbegin(),
name.rend(),
[](char v) { return v == '[' || v==']'; }).base());
There was a problem hiding this comment.
Your statement using string::assign and find_it_not looks more concise, but it was Qing's code and it works with no issue, so I prefer not to change it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Merge into CDT release/1.8.x to solve an issue to compile contract in eos/unittests/test-contracts/kv_addr_book/ correctly
Here to make toolchain test successful, two commits are cherry picked, one is from my PR1193 , the other is from Qing's early change on map of map in abigen.hpp
API Changes
Documentation Additions