E2Eテストが大量に失敗するための対策 #6353
Merged
E2Eテストが大量に失敗するための対策 #6353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.3 #6353 +/- ##
==========================================
- Coverage 82.83% 82.82% -0.01%
==========================================
Files 480 480
Lines 27093 27093
==========================================
- Hits 22442 22441 -1
- Misses 4651 4652 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
``` 1. amOnPage($url); 2. click($content); 3. sendKeys($key) ``` という順番で処理しているが、実際の画面遷移は click の後になってしまう場合がある
nanasess
force-pushed
the
chrome-129-fix-problem
branch
from
8c71343 to
82a1e4e
Compare
refactor(tests):# modified: codeception/acceptance/EF09ThrottlingCest.php remove unnecessary wait statements in EA06# Changes not staged for commit: Contents# modified: codeception/_support/AcceptanceTester.php ManagementCest This change eliminates redundant `wait` calls that were previously# .php-version added before `amOnPage()` to# CustomErrorPage42_20221119.tar.gz ensure proper page transitions. The code# app/config/eccube/packages/purchaseflow.yaml.orig is now cleaner and relies on more robust mechanisms for handling page transitions.
nanasess
force-pushed
the
chrome-129-fix-problem
branch
from
35741a1 to
6595e91
Compare
dotani1111
approved these changes
Apr 16, 2025
zeniya0000
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
Chrome 129.0.6662.0 の何らかの改修が原因で、E2Eテストが大量に失敗するようになったための対策
Fixes #6344
方針(Policy)
主に以下のようなケースでテストが通らなくなった
Facebook\WebDriver\Exception\StaleElementReferenceExceptionが発生する<selector name> was not found.となる)対策として、主に以下の対応をした
実装に関する補足(Appendix)
その他、 php-cs-fixer による修正を含みます
テスト（Test)
E2Eテストが通ることを確認
相談（Discussion）
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目