Implemented the service-info endpoint #43
Conversation
There was a problem hiding this comment.
Looks good for now.
The service-info is still being discussed in ga4gh/refget#39 so I'm sure their will be other changes
| "type": "string" | ||
| } | ||
| }, | ||
| "sorted_names_length_pairs":{ |
There was a problem hiding this comment.
I made a typo in the issue and we settled on using hyphen instead of underscore.
Of course we should make sure the names match between the service info and the API but the correct one is the one bellow.
| "sorted_names_length_pairs":{ | |
| "sorted-name-length-pairs":{ |
There was a problem hiding this comment.
actually we decided on underscores, right?
| "documentationUrl": "https://www.ebi.ac.uk/eva/....", | ||
| "updatedAt": "08-24-2023", | ||
| "environment": "dev", | ||
| "version": "tagged version", |
There was a problem hiding this comment.
As a future improvement maybe version and updatedAt should be filled dynamically, even if the rest isn't.
Also @tcezard, what's the difference between this version and type.version? This one is the code version and the other is the spec version?
There was a problem hiding this comment.
For the versions:
- version is the version of the service
- type.version is the version of the API
| }, | ||
| "sorted_names_length_pairs":{ | ||
| "type": "array", | ||
| "description": "objects composed of length and name of a sequence digested and ordered lexicographically", |
There was a problem hiding this comment.
| "description": "objects composed of length and name of a sequence digested and ordered lexicographically", | |
| "description": "Objects composed of length and name of a sequence digested and ordered lexicographically.", |
It should be |
|
@nsheff I'll raise an issue for that to do the necessary refactoring |
closes #37
Implemented the service-info endpoint.
I actually used the same file provided here by @tcezard.
I did one change in the
lengthsattribute's type that I changed it intostring, which is how it is defined in our API, and we'll consider updating it intointegerafter we do the refactor in our API.I would like to know whether we should use
sorted_names_length_pairs, as provided in the service-info file, orsorted_name_length_pairsas we defined it in our java model.