New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REVIT-232867 - Revise Input Port Descriptions #3139

Open

johnpierson wants to merge 5 commits into DynamoDS:master from johnpierson:johnP_ReviseInputPortDescriptions

Member

johnpierson commented Feb 10, 2025

Purpose

To revise input port descriptions for these nodes: https://github.com/search?q=repo%3ADynamoDS%2FDynamoRevit+path%3A%2F%5Esrc%5C%2F%2F++%22+meters%22&type=code

They currently state input as "meters" from the early days of Dynamo, when it was unitless.

Declarations

Check these if you believe they are true

The code base is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
Snapshot of UI changes, if any.

Reviewers

FYIs

@Amoursol @achintyabhat @emru-y

johnpierson added 5 commits

February 10, 2025 08:34


          Update PerspectiveView.cs

b54d7c0


          Update FamilyInstance.cs

320fa3a


          Update ReferencePoint.cs

cbc2d4a


          Update AxonometricView.cs

93d8fb2


          Update SectionView.cs

d63462d

Member Author

johnpierson commented Feb 10, 2025

Task here: REVIT-232867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet