Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7368: CER crash - catch exception from dynamomessagebox #15850

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aparajit-pratap
Copy link
Contributor

Purpose

DYN-7368: CER crash - catch exception from dynamomessagebox

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Catch unexpected exceptions thrown from DynamoMessageBox while saving backup files.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7368

Copy link
Contributor

@zeusongit zeusongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way we can log the exception here?

@aparajit-pratap
Copy link
Contributor Author

aparajit-pratap commented Feb 25, 2025

@avidit can you tell me how I can investigate the UI smoke test failures? I see that these are test complete tests. Any idea why these could be failing from this PR?

Hmm, it looks like these tests are failing with other PRs too.

@avidit
Copy link
Contributor

avidit commented Feb 25, 2025

@avidit can you tell me how I can investigate the UI smoke test failures? I see that these are test complete tests. Any idea why these could be failing from this PR?

Hmm, it looks like these tests are failing with other PRs too.

We are not maintaining these tests anymore. I am working on replacing these with AGT tests. We can ignore these failures for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants