Cache FunctionDescriptor Category property #15834
Open
+83
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The Category property of the FunctionDescriptor potentially calls .GetName on every assembly every time it is accessed, and this takes a lot of time during workspace loading. By caching the category, this price of accessing the assemblies is only paid once.
There might be issues if the assemblies are reloaded, but the FunctionDescriptor is not?
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
N/A
Reviewers
@mjkkirschner
FYIs
@dimven