DYN-6908 string from object float precision #15226
Conversation
When using the StringFromObject with an entry of a double value with more than 6 decimals places after point was truncating to 6 to I've made a change to use 17 (double types precision is between 15 and 17).
Calculating the precision dynamically based in the number of decimals provided in the double value.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6908
|
This is a GIF showing the expected behavior. |
|
I think that modifying the standard output this node has produced for the last 10 years needs to be considered as a potential API behavior break. I think a more backwards compatible solution like: |
|
Hi @mjkkirschner The proposal does make sense, thinking about it, I wonder if this is the case that bug becomes feature.. So I am not sure one way or the other, since this was originally panned for 3.2.0 release, if we took the other approach, how complex it would be? FYI: @Amoursol |
Agree with @mjkkirschner that this behavior change will impact legacy graphs that have been built specifically with this kind of output in mind. In other scenarios we have the Dynamo UI showcase numbers graphically that differ from what is actually happening under the hood, so we don't have consistency. The more holistic fix is as Mike mentioned, adding a new overloaded node that enables the user to specify the precision. Given the code in this PR, it feels like a pretty simple addition? Can re-use icons, only need to recreate Extended Help and Sample that should be quick enough. Thoughts? |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
|
There is already a proposal for fixing this bug in a different way. |
Purpose
Calculating the double precision dynamically based in the number of decimals provided in the double value.
When using a double value with more than 15 decimals and passing the value to the StringFromObject node was truncating the output to use only 6 decimals so I did a fix in a way that the precision will be calculated dynamically.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Calculating the double precision dynamically based in the number of decimals provided in the double value.
Reviewers
@QilongTang
FYIs
@mjkkirschner @jnealb