Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6693 Alert user for duplicate files when publishing package #15225

Merged
merged 5 commits into from
May 20, 2024

Conversation

zeusongit
Copy link
Contributor

@zeusongit zeusongit commented May 16, 2024

Purpose

When files with same name exist in the package being uploaded by the publisher, only one of those duplicate files is retained, as they get merged into the same directory when retain folder structure toggle is off.
After this change the user will be alerted this when it occurs.

The alert message text is being finalized by the UX, and will be updated as a resource string soon.
Strings added to resource string
Introduced a new dialog box with scrollable body for longer list of duplicate files.

Screenshot 2024-05-17 at 1 37 23 PM
Screenshot 2024-05-17 at 2 47 34 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Alert user when publishing duplicated named files

Reviewers

@DynamoDS/dynamo

@zeusongit zeusongit changed the title [DYN-6693] Alert user for duplicate files when publishing package DYN-6693 Alert user for duplicate files when publishing package May 16, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6693

Copy link

github-actions bot commented May 17, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang added this to the 3.2 milestone May 17, 2024
@zeusongit zeusongit merged commit d980f2d into DynamoDS:master May 20, 2024
20 of 22 checks passed
@zeusongit zeusongit deleted the pm-file-warn branch May 20, 2024 16:54
Enzo707 pushed a commit to Enzo707/Dynamo that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants