Add support for value types #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piccirello
reviewed
May 16, 2024
apazzolini
force-pushed
the
andre/value-types
branch
from
3dd8af8
to
8cde9f9
Compare
kyle-mcguire
previously approved these changes
May 20, 2024
nmanoogian
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds read/write support for value types in the CLI.
Notably, this destructures the
typefield inside of the value type properties for direct usage. If we ever support additional metadata on value types (e.g. regex with a pattern), we'll add a second CLI flag for setting it. This keeps the 99% case cleaner.Closes ENG-7909