Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focused active preloader sass to direct child #6554

Open
wants to merge 1 commit into
base: v1-dev
Choose a base branch
from

Conversation

nmggithub
Copy link

Proposed changes

This fixes a bug where spinners inside a collapsible will always stay on, because the parent list item will have the class "active".

Screenshots (if appropriate) or codepen:

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This fixes a bug where spinners inside a collapsible will always stay on, because the parent list item will have the class "active"
@nmggithub
Copy link
Author

This has been sitting here for several months. This is a very minor change. Can someone please look at it?

@Smankusors
Copy link

This has been sitting here for several months. This is a very minor change. Can someone please look at it?

this repo... idk...

but if you want, you can contribute to the forked one instead https://github.com/materializecss/materialize 😉

also, consider adding an example/a codepen/the screenshots, it will help maintainers see what's the problem are.

@nmggithub
Copy link
Author

This has been sitting here for several months. This is a very minor change. Can someone please look at it?

this repo... idk...

but if you want, you can contribute to the forked one instead https://github.com/materializecss/materialize

also, consider adding an example/a codepen/the screenshots, it will help maintainers see what's the problem are.

I'll take a look. Thanks for turning me onto it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants