Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1469: Fix download button on old summary page #840

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1469

Summary:

On the (old) summary page, there is a button marked "Download MTZ file", but it just gives a 404 error. It appears the API endpoint was removed in 2b78502 (see changes to Download.php).

Changes:

  • Change link from /download/id/<%-DCID%>/aid/<%-AID%> to /download/ap/archive/<%-AID%> to match the new endpoint
  • Remove old "delete me" comment

To test:

  • Go to a summary page for a visit eg /dc/summary/visit/cm37235-4
  • Check the tooltip for the download button now says "Download autoprocessing archive"
  • Check clicking the button downloads a zip of autoprocessing files

@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R5.2 November 12, 2024 10:03
@ndg63276 ndg63276 merged commit 9317745 into pre-release/2024-R5.2 Nov 12, 2024
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-1469/download-button-fails-on-old-summary branch November 12, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants