Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-926: Feature advanced filter do not show logic #672

Open
wants to merge 13 commits into
base: prerelease
Choose a base branch
from
Open

LIMS-926: Feature advanced filter do not show logic #672

wants to merge 13 commits into from

Conversation

NKatti2011
Copy link
Collaborator

JIRA ticket: TICKET-926

Summary:

The advanced filters on the summary page do not show logic of selected filter parameters.

Changes:

  • Component added to component utils which takes an object and displays the values in a pill form in the DOM
  • Component is an input where if clicked then will utilise the dialog-modal component

To test:

  • Go to summary page and click on Advanced Search
  • Click on the + button and then on the input box where a dialogue box should appear
  • Make a selection and, when clicking out of the component, check that the logic that appears is as expected.

@NKatti2011 NKatti2011 changed the title Feature/lims 926/advanced filter do not show logic LIMS-926: Feature advanced filter do not show logic Sep 25, 2023
MattPrit
MattPrit requested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@MattPrit MattPrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things we saw going over the code

NKatti2011 and others added 11 commits September 25, 2023 16:28
@NKatti2011 @MattPrit
Update client/src/js/modules/summary/views/summary.vue
2c31065 
Co-authored-by: Matthew Pritchard <[email protected]>
@NKatti2011 @MattPrit
Update client/src/js/app/components/multi-input-dialogue.vue
77198d0 
Co-authored-by: Matthew Pritchard <[email protected]>
@NKatti2011
remove handleclickoutside and clearopts
5012c63
@NKatti2011
remove test console.logs
e85ed19
@NKatti2011 @MattPrit
Update client/src/js/app/components/multi-input-dialogue.vue
217932a 
Co-authored-by: Matthew Pritchard <[email protected]>
@NKatti2011 @MattPrit
Update client/src/js/modules/summary/views/summary.vue
0af71d6 
Co-authored-by: Matthew Pritchard <[email protected]>
@NKatti2011
remove handleselectedchange
cddc2ac
@NKatti2011
Merge branch 'feature/LIMS-926/advanced-filter-do-not-show-logic' of h…
7a1de51 
…ttps://github.com/DiamondLightSource/SynchWeb into feature/LIMS-926/advanced-filter-do-not-show-logic
@NKatti2011 @MattPrit
Update client/src/js/modules/summary/views/summary.vue
cec7295 
Co-authored-by: Matthew Pritchard <[email protected]>
@NKatti2011
change input to be div
1f94c91
@NKatti2011
Merge branch 'feature/LIMS-926/advanced-filter-do-not-show-logic' of h…
ba85510 
…ttps://github.com/DiamondLightSource/SynchWeb into feature/LIMS-926/advanced-filter-do-not-show-logic
@MattPrit MattPrit removed their request for review January 9, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattPrit MattPrit MattPrit requested changes

@ndg63276 ndg63276 Awaiting requested review from ndg63276

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NKatti2011 @MattPrit