Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootspec: add a specialisation test #112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RaitoBezarius
Copy link
Contributor

Description

This test is failing atm.

Checklist
  • Built with cargo build
  • Formatted with cargo fmt
  • Linted with cargo clippy
  • Ran tests with cargo test
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)

Comment on lines +160 to +178
"org.nixos.specialisation.v1": {
"variant": {
"init": "/nix/store/4z5jmmhdvhyrpw08ic05bsb3hnbf365w-nixos-system-machine-23.05pre-git/init",
"initrd": "/nix/store/kqv7bsb9ji7yhknim3laviz37b6smn2b-initrd-linux-6.1.25/initrd",
"initrdSecrets": "/nix/store/f3kvscyhly5p8qybcmcgs0rj9lr3zplj-append-initrd-secrets/bin/append-initrd-secrets",
"kernel": "/nix/store/v5j1pn8nd7h3i0w6kg1fpsa0mlxcgda4-linux-6.1.25/bzImage",
"kernelParams": [
"console=ttyS0",
"panic=1",
"boot.panic_on_fail",
"clock=acpi_pm",
"loglevel=7",
"net.ifnames=0"
],
"label": "NixOS Stoat 23.05pre-git (Linux 6.1.25)",
"system": "x86_64-linux",
"toplevel": "/nix/store/4z5jmmhdvhyrpw08ic05bsb3hnbf365w-nixos-system-machine-23.05pre-git"
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec says that there must be an org.nixos.bootspec.v1 key under the specialisation name, and you're missing that; that's why it fails:

  "org.nixos.specialisation.v1": {
    // Each key in this object corresponds to a specialisation as defined by the `specialisation.<name>` NixOS option.
    "<name>": {
      "org.nixos.bootspec.v1": {
        // See above
      }
    }
  },
Suggested change
"org.nixos.specialisation.v1": {
"variant": {
"init": "/nix/store/4z5jmmhdvhyrpw08ic05bsb3hnbf365w-nixos-system-machine-23.05pre-git/init",
"initrd": "/nix/store/kqv7bsb9ji7yhknim3laviz37b6smn2b-initrd-linux-6.1.25/initrd",
"initrdSecrets": "/nix/store/f3kvscyhly5p8qybcmcgs0rj9lr3zplj-append-initrd-secrets/bin/append-initrd-secrets",
"kernel": "/nix/store/v5j1pn8nd7h3i0w6kg1fpsa0mlxcgda4-linux-6.1.25/bzImage",
"kernelParams": [
"console=ttyS0",
"panic=1",
"boot.panic_on_fail",
"clock=acpi_pm",
"loglevel=7",
"net.ifnames=0"
],
"label": "NixOS Stoat 23.05pre-git (Linux 6.1.25)",
"system": "x86_64-linux",
"toplevel": "/nix/store/4z5jmmhdvhyrpw08ic05bsb3hnbf365w-nixos-system-machine-23.05pre-git"
}
}
"org.nixos.specialisation.v1": {
"variant": {
"org.nixos.bootspec.v1": {
"init": "/nix/store/4z5jmmhdvhyrpw08ic05bsb3hnbf365w-nixos-system-machine-23.05pre-git/init",
"initrd": "/nix/store/kqv7bsb9ji7yhknim3laviz37b6smn2b-initrd-linux-6.1.25/initrd",
"initrdSecrets": "/nix/store/f3kvscyhly5p8qybcmcgs0rj9lr3zplj-append-initrd-secrets/bin/append-initrd-secrets",
"kernel": "/nix/store/v5j1pn8nd7h3i0w6kg1fpsa0mlxcgda4-linux-6.1.25/bzImage",
"kernelParams": [
"console=ttyS0",
"panic=1",
"boot.panic_on_fail",
"clock=acpi_pm",
"loglevel=7",
"net.ifnames=0"
],
"label": "NixOS Stoat 23.05pre-git (Linux 6.1.25)",
"system": "x86_64-linux",
"toplevel": "/nix/store/4z5jmmhdvhyrpw08ic05bsb3hnbf365w-nixos-system-machine-23.05pre-git"
}
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants