Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add none filter to memento keyword #9560

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Add none filter to memento keyword #9560

merged 2 commits into from
Jun 30, 2023

Conversation

d-costa
Copy link
Contributor

@d-costa d-costa commented Jun 7, 2023 •
edited
Loading

  • Add memento:none filter to highlight weapons with an empty memento socket.
  • If there is a more elegant way to filter empty memento sockets let me know :)
  • Close Filter Suggestion: memento:none #9366

robojumper
robojumper approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@robojumper robojumper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! A small improvement could be updating the "HasMemento" localization entry, which currently says "Shows crafted weapons that currently have a memento inserted." (since the none filter does the opposite).

@d-costa d-costa requested a review from robojumper June 8, 2023 22:33
@bhollis bhollis merged commit c4c8864 into DestinyItemManager:master Jun 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhollis bhollis bhollis approved these changes

@robojumper robojumper Awaiting requested review from robojumper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter Suggestion: memento:none
3 participants
@d-costa @bhollis @robojumper