Make DimItem#itemCategoryHashes type be ItemCategoryHash #10728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhollis
requested review from
FlaminSarge,
delphiactual,
ryan-rushton and
robojumper
FlaminSarge
reviewed
Sep 16, 2024
| @@ -45,7 +46,7 @@ describe('vaultWeaponGroupingSelector', () => { | |||
| { | |||
| ...firstItem, | |||
| typeName: undefined as unknown as string, | |||
| itemCategoryHashes: [0], | |||
| itemCategoryHashes: [0 as ItemCategoryHashes], | |||
There was a problem hiding this comment.
Do we have an ItemCategoryHash.Invalid def we can use instead of 0 for any of the places we're using/comparing to 0?
There was a problem hiding this comment.
No - this test is intentionally using an invalid hash for some reason.
There was a problem hiding this comment.
Was also looking at https://github.com/DestinyItemManager/DIM/pull/10728/files#diff-f5fb26c29f2cdf8869105eb04a5d34ee01d285f2b4a163a23bf88488be6c0a86R108 re: making a definition for Invalid hash.
There was a problem hiding this comment.
Yeah, in that case it should be undefined, not zero. It's modeling the absence of a hash, not a special invalid hash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seemed like it would be nice for
DimItem#itemCategoryHashesto actually be typedItemCategoryHash[]. TS is weirdly loose about this - it doesn't catch the special inverted item category hashes we use (e.g. for grenade launchers) but it's still an improvement.