Feat/wishlist category hash #10672
Closed
Feat/wishlist category hash #10672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you maybe describe what this change is? |
bhollis
reviewed
Aug 16, 2024
src/app/wishlists/selectors.test.ts
Outdated
| wishListsSelector, | ||
| } from './selectors'; | ||
|
|
||
| const chance = Chance(); |
There was a problem hiding this comment.
I'm not especially a fan of random data in tests - it makes errors hard to reproduce. It'd be much nicer to have stable mock data, or better, data pulled from a real profile export.
There was a problem hiding this comment.
I can do that if that's preferred. Alternatively, I can print the seed that was used when the test started so it can be reran with deterministic values.
There was a problem hiding this comment.
If it's possible, using data from the checked-in profile export is the nicest, since we know it followed the rules of the Bungie API at some point.
whyayala
force-pushed
the
feat/wishlist-category-hash
branch
from
068c0f3
to
d2a8727
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, dim's armory will not display wishlist rolls where the item hash matches the dim item category (so if a wishlist includes a roll that uses the auto rifle hash, the matching roll is not displayed in the armory).
This feature makes it possible to match a wishlist item based on a dim items category hashes.