Merge pull request #10348 from DestinyItemManager/is-shiny

is:shiny for brave weapons

config/i18n.json

@@ -294,6 +294,7 @@
  "RarityTier": "Shows items based on their rarity tier.",
  "Reforgeable": "Shows items that can be reforged at the Gunsmith.",
  "Release": "Available from release <i>{{release}}</i>",
+ "Shiny": "Shows BRAVE weapons with a limited-edition ornament.",
  "Weapon": "Shows items that are weapons.",
  "Armor": "Shows items that are armor.",
  "Cosmetic": "Shows items that are flair or cosmetic.",

docs/CHANGELOG.md

@@ -1,5 +1,8 @@
 ## Next
 
+* Fixed max stat constraints sometimes being not shown in Loadout parameters.
+* `is:shiny` filter to find limited-edition BRAVE weapons.
+
 ## 8.16.0 <span class="changelog-date">(2024-04-14)</span>
 
 * Loadouts with only armor mods, or only fashion (shaders & ornaments), now display a symbol in the equip dropdown, and can be filtered from among other loadouts.

src/app/search/__snapshots__/search-config.test.ts.snap

@@ -104,6 +104,7 @@ exports[`buildSearchConfig generates a reasonable filter map: is filters 1`] = `
  "shaded",
  "shaped",
  "shapeddupe",
+ "shiny",
  "ships",
  "shotgun",
  "sidearm",

src/app/search/search-filters/sockets.ts

@@ -82,6 +82,18 @@ const socketFilters: FilterDefinition[] = [
  (item) =>
  matchesCuratedRoll(d2Definitions!, item),
  },
+ {
+ keywords: 'shiny',
+ description: tl('Filter.Shiny'),
+ destinyVersion: 2,
+ filter: () => (item) =>
+ item.sockets?.allSockets.some(
+ (s) =>
+ s.plugOptions.some(
+ (s) => s.plugDef.plug.plugCategoryIdentifier === 'holofoil_skins_shared',
+ ), //
+ ),
+ },
  {
  keywords: 'extraperk',
  description: tl('Filter.ExtraPerk'),

src/locale/en.json

@@ -298,6 +298,7 @@
  "RetiredPerk": "Shows weapons with perks that no longer obtainable.",
  "SearchPrompt": "Search available filter commands",
  "Season": "Shows items from which season of Destiny 2 they appeared in.",
+ "Shiny": "Shows BRAVE weapons with a limited-edition ornament.",
  "StackFull": "Show items which are at-capacity for their stack (Enhancement Cores, Strange Coins, Gunsmith Materials etc)",
  "StackLevel": "Shows items based on the quantity of items in its stack.",
  "Stackable": "Shows items that can stack (ammo synths, strange coin, etc)",