Use libstdc++ implementation of std::bitset if other standard library is used #517
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
p-senichenkov
force-pushed
the
fix-516
branch
from
98340f7 to
ac5c062
Compare
p-senichenkov
force-pushed
the
fix-516
branch
3 times, most recently
from
40394c1 to
269a744
Compare
p-senichenkov
force-pushed
the
fix-516
branch
2 times, most recently
from
691dea7 to
cc31c8f
Compare
p-senichenkov
force-pushed
the
fix-516
branch
from
cc31c8f to
8bfd025
Compare
p-senichenkov
force-pushed
the
fix-516
branch
4 times, most recently
from
7bb52ce to
a02c213
Compare
Implement bitset and bitset tests
Use implemented bitset instead of std::bitset in: - fdep::FDTreeElemend - ::FDep - od::AttributeSet - dc::Predicate - ::CommonClueSetBuilder
Remove src/core/bitset_extensions, because now it's not needed
p-senichenkov
force-pushed
the
fix-516
branch
from
a02c213 to
f36377b
Compare
Specialize std::hash instead of hash inside of namespace std to avoid UB
There was a problem hiding this comment.
Looks ok to me, but I can't say with much certainty that using Apache and GPL-3 with our AGPL is fully compatible, as I'm not a lawyer. But if you trust the information on the Internet, then everything seems ok. For example:
https://opensource.stackexchange.com/a/8271
P.S. I didn't look a lot at the code in the added bitset.h as I trust that it was copied from gcc and doesn't need review :)
| FlipAll, Flip, FlipInvalidIndex, ToString, ToStringCustomChars, ToULong, | ||
| ToULLong, And, Or, Xor, ToStream, FromStream, FindFirst, FindNext); | ||
|
|
||
| using BitsetSizes = ::testing::Types<BitsetSizeParam<8>, BitsetSizeParam<128>>; |
There was a problem hiding this comment.
Why exactly these values? Are they used in our algorithms? Is 64 also used? Maybe we should put all our values from all used bitsets there?
There was a problem hiding this comment.
These are just convenient values for testing. 8-bit is a single-word bitset (with most zeros), 128-bit contains at least 2 words on any system. I believe that 64-bit will work fine too, considering these two work.
Copy
libstdc++implementation ofstd::bitsetto use it when project is compiled withlibc++(and possibly other STL implementations). Fixes #516.Here are macOS Apple Clang run times after this fix:
