Miscellaneous config fixups #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`src/algorithms` contains the logic of the algorithms themselves, and options are not logic. `src/util` seems like a better place for them, given that they are something that is common to all algorithms, just like `Progress`.
polyntsov
requested changes
May 19, 2023
BUYT-1
force-pushed
the
config-fixups
branch
2 times, most recently
from
2333119 to
e79f30d
Compare
Specifying full names for things in algos::config::{names,descriptions}
namespaces can get annoying but `using namespace...` declarations are
repetitive, so this macro should be used when an algorithm registers an
option using the util::config::Option class directly.
polyntsov
approved these changes
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move config to util, add
ConfigureFromFunction, pipeline fixes.