Simplify configuration #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
BUYT-1
force-pushed
the
simplify-options
branch
from
7686ea3 to
60dd9d6
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
BUYT-1
force-pushed
the
simplify-options
branch
from
60dd9d6 to
cfa4afd
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
BUYT-1
force-pushed
the
simplify-options
branch
from
cfa4afd to
b37a046
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
BUYT-1
force-pushed
the
simplify-options
branch
from
b37a046 to
6fd7a9f
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
BUYT-1
force-pushed
the
simplify-options
branch
2 times, most recently
from
190d624 to
0bfbe6e
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
BUYT-1
force-pushed
the
simplify-options
branch
from
0bfbe6e to
36724aa
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
BUYT-1
force-pushed
the
simplify-options
branch
from
36724aa to
8a32e11
Compare
BUYT-1
force-pushed
the
simplify-options
branch
4 times, most recently
from
a215cb6 to
16d3c66
Compare
BUYT-1
force-pushed
the
simplify-options
branch
3 times, most recently
from
d45ba43 to
672e45b
Compare
polyntsov
requested changes
Apr 3, 2023
BUYT-1
force-pushed
the
simplify-options
branch
2 times, most recently
from
d6f5ab1 to
eded8e7
Compare
std::string_view is too simple to pass by reference.
There are no situations where the descriptions.h header is needed without names.h, thus this header is added for brevity.
polyntsov
requested changes
Apr 8, 2023
BUYT-1
force-pushed
the
simplify-options
branch
2 times, most recently
from
d7eb197 to
f11896f
Compare
Adapted for the new CommonOption and split into type and option itself as sometimes the option is not needed.
The descriptions.h file does not get included transitively in main.cpp anymore.
polyntsov
approved these changes
Apr 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make option creation less verbose, separate types from options, clean up TypoMiner error check, add header with names and descriptions, simplify option-related classes, rewrite configuration accordingly, simplify option value type.