Skip to content

Commit

Permalink
remove project version
Browse files Browse the repository at this point in the history
  • Loading branch information
DenysVuika committed Jun 23, 2023
1 parent 86b3c8b commit 148df2e
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 30 deletions.
1 change: 0 additions & 1 deletion src/assets/sql/schema.sql
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ BEGIN;

CREATE TABLE IF NOT EXISTS projects (
name TEXT,
version TEXT,
created_on DATETIME DEFAULT CURRENT_TIMESTAMP NOT NULL,
origin TEXT
);
Expand Down
33 changes: 12 additions & 21 deletions src/db.rs
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ pub struct Snapshot {
pub struct ProjectInfo {
pub id: i64,
pub name: String,
pub version: String,
pub created_on: DateTime<Utc>,
pub origin: Option<String>,
}
Expand Down Expand Up @@ -157,15 +156,10 @@ pub fn create_connection(working_dir: &Path) -> Result<Connection> {
Ok(conn)
}

pub fn create_project(
conn: &Connection,
name: &String,
version: &String,
origin: &str,
) -> Result<i64> {
pub fn create_project(conn: &Connection, name: &String, origin: &str) -> Result<i64> {
conn.execute(
"INSERT INTO projects (name, version, origin) VALUES (?1, ?2, ?3)",
params![name, version, origin],
"INSERT INTO projects (name, origin) VALUES (?1, ?2)",
params![name, origin],
)?;
Ok(conn.last_insert_rowid())
}
Expand All @@ -187,15 +181,14 @@ pub fn create_tag(conn: &Connection, pid: i64, name: &str) -> Result<i64> {
}

pub fn get_projects(conn: &Connection) -> Result<Vec<ProjectInfo>> {
let mut stmt = conn.prepare("SELECT OID, name, version, created_on, origin FROM projects")?;
let mut stmt = conn.prepare("SELECT OID, name, created_on, origin FROM projects")?;
let rows = stmt
.query_map([], |row| {
Ok(ProjectInfo {
id: row.get(0)?,
name: row.get(1)?,
version: row.get(2)?,
created_on: row.get(3)?,
origin: row.get(4)?,
created_on: row.get(2)?,
origin: row.get(3)?,
})
})?
.filter_map(|entry| entry.ok())
Expand All @@ -205,15 +198,14 @@ pub fn get_projects(conn: &Connection) -> Result<Vec<ProjectInfo>> {

pub fn get_project_by_name(conn: &Connection, name: &str) -> Result<ProjectInfo> {
let project_info = conn.query_row(
"SELECT OID, name, version, created_on, origin FROM projects WHERE name=:name",
"SELECT OID, name, created_on, origin FROM projects WHERE name=:name",
params![name],
|row| {
Ok(ProjectInfo {
id: row.get(0)?,
name: row.get(1)?,
version: row.get(2)?,
created_on: row.get(3)?,
origin: row.get(4)?,
created_on: row.get(2)?,
origin: row.get(3)?,
})
},
)?;
Expand All @@ -222,15 +214,14 @@ pub fn get_project_by_name(conn: &Connection, name: &str) -> Result<ProjectInfo>

pub fn get_project_by_snapshot(conn: &Connection, sid: i64) -> Result<ProjectInfo> {
let project_info = conn.query_row(
"SELECT p.OID, p.name, p.version, p.created_on, p.origin FROM snapshots s JOIN projects p ON p.OID = s.pid WHERE s.OID=:sid",
"SELECT p.OID, p.name, p.created_on, p.origin FROM snapshots s JOIN projects p ON p.OID = s.pid WHERE s.OID=:sid",
params![sid],
|row| {
Ok(ProjectInfo {
id: row.get(0)?,
name: row.get(1)?,
version: row.get(2)?,
created_on: row.get(3)?,
origin: row.get(4)?,
created_on: row.get(2)?,
origin: row.get(3)?,
})
},
)?;
Expand Down
5 changes: 1 addition & 4 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@ pub async fn run(config: &Config) -> Result<()> {

let conn = db::create_connection(&config.output_dir)?;
let package = PackageJsonFile::from_file(package_json_path)?;

let name = package.name.unwrap();
let version = package.version.unwrap();

let pid = match db::get_project_by_name(&conn, &name) {
Ok(project_info) => {
Expand Down Expand Up @@ -61,8 +59,7 @@ pub async fn run(config: &Config) -> Result<()> {
Err(_) => {
log::info!("Creating project `{}`", &name);
let remote_url = project.remote_url()?;
// TODO: version should be part of the snapshot as package.json values differ in branches/tags
db::create_project(&conn, &name, &version, &remote_url)?
db::create_project(&conn, &name, &remote_url)?
}
};

Expand Down
1 change: 0 additions & 1 deletion src/server.rs
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ async fn get_snapshot_project(
let project = db::get_project_by_snapshot(conn, sid).unwrap();
let result = json!({
"name": project.name,
"version": project.version,
"created_on": snapshot.created_on,
"origin": project.origin,
"branch": snapshot.branch,
Expand Down
4 changes: 1 addition & 3 deletions static/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@
return html`
<section class="hero is-primary">
<div class="hero-body">
<p class="title">
${project.name} ${project.version}
</p>
<p class="title">${project.name}</p>
<p class="subtitle">${project.created_on}</p>
</div>
</section>
Expand Down

0 comments on commit 148df2e

Please sign in to comment.