Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nodata value to "empty array" #240

Merged
merged 1 commit into from
Jan 28, 2025
Merged

add nodata value to "empty array" #240

merged 1 commit into from
Jan 28, 2025

Conversation

roeldegoede
Copy link
Collaborator

Issue addressed

Fixes #

Explanation

When starting with a very small dataset, it is quite likely that da1 is an xarray full with nan values. Without a proper nodata value, we run into trouble in the merge function, hence added explicitly now.

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Updated documentation if needed
  • Updated changelog.rst if needed

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@roeldegoede roeldegoede requested a review from Leynse January 28, 2025 12:56
@Leynse Leynse merged commit 94b514e into main Jan 28, 2025
1 check passed
@Leynse Leynse deleted the fix/merge_datasets branch January 28, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants