Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide decent warning when all waterlevel boundary points are outsid… #237

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

roeldegoede
Copy link
Collaborator

…e of region+buffer.

Issue addressed

Fixes #222

Explanation

A clear warning is now provided, hope that is sufficient. After the warning is raised, users can incrase their buffer.

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Updated documentation if needed
  • Updated changelog.rst if needed

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@roeldegoede roeldegoede requested a review from Leynse January 22, 2025 08:22
Copy link
Collaborator

@Leynse Leynse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestions, thanks Roel!

@roeldegoede roeldegoede merged commit 3849deb into main Jan 23, 2025
5 checks passed
@roeldegoede roeldegoede deleted the wlev_bnd_error branch January 23, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add options to setup_waterlevel_forcing for user friendliness
2 participants