added xu_open_dataset wrapper #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeldegoede
approved these changes
Jan 15, 2025
roeldegoede
added a commit
that referenced
this pull request
Jan 22, 2025
* potential bugfix havg * undo previous commit and update computation of wet fractions (and increased readability) * fix wet fractions and corresponding havg * add dependencies * add reading/writing quadtree netcdf files * add read/write subgrid quadtree * add quadtree io in main sfincs.py * Solve some linting warnings * make datashader optional dep * add bounds property (since the original calls read_grid) and remove grid api * fixing read_results and plot_basemap for quadtree models. Also fixed #133 * add quadtree IO tests * extended tests for quadtree io, plot_basemap and read_results * imrpoved downscaling methods (both bugfixes and allow for ugrids) * pre-commit linting * pre-commit test-data * changed fix for plotting; not longer reprojecting to epsg4326 by default but using another cartopy projection * fix pyflwdir version for now (to be investigated) * fix typo in pyproject.toml * test fixing docs workflows, since Mambaforge gets deprecated ... * miniforge3? * Delete tests/data/sfincs_test_quadtree/sfincs_log.txt * bugfix so sfincs_his.nc files are closed correctly (#232) * bugfix so that the .nc file is closed automatically when erroring or when leaving the context manager (with block). see pydata/xarray#1629 (comment) * fixed all occurences of xr.opendataset with the safe open&close pattern * review comments by Roel * fix linting --------- Co-authored-by: roeldegoede <[email protected]> * added xu_open_dataset wrapper (#236) * added xu_open_dataset wrapper. * load_dataset -> open_dataset * linting --------- Co-authored-by: roeldegoede <[email protected]> --------- Co-authored-by: DirkEilander <[email protected]> Co-authored-by: Tim Leijnse <[email protected]> Co-authored-by: LuukBlom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #
Explanation
Explain how you addressed the bug/feature request, what choices you made and why.
Checklist
mainAdditional Notes (optional)
Add any additional notes or information that may be helpful.