Phase wise operation integration with d-flow fm #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not set in the csv.
vrielin
approved these changes
Feb 4, 2025
…n cause discharge reversals.
vrielin
reviewed
Feb 6, 2025
| @@ -166,10 +166,16 @@ static int sealock_phase_results_to_results(sealock_state_t *lock) { | |||
| /* Set a correction for the current phase results for possibly skipping a bit of the start. */ | |||
| static int sealock_apply_phase_wise_result_correction(sealock_state_t *lock, time_t time, | |||
| time_t duration, zsf_results_t *previous) { | |||
| // Note: We assume the timestepping from DIMR will be constant and non-zero. | |||
There was a problem hiding this comment.
And that's reasonable at this moment, time can only be specified as [tstart, tstep, tstop] ,
https://content.oss.deltares.nl/schemas/dimr-1.3.xsd
vrielin
approved these changes
Feb 6, 2025
erwin-mulder
deleted the
62-phase-wise-operation-integration-with-d-flow-fm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done: