corrected comments

Deltares-research · Jun 17, 2024 · 723d4b3 · 723d4b3
1 parent 74bf06f
commit 723d4b3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/kenmerkendewaarden/gemiddeldgetij.py b/kenmerkendewaarden/gemiddeldgetij.py
@@ -322,7 +322,7 @@ def reshape_signal(ts, ts_ext, HW_goal, LW_goal, tP_goal=None):
     
     time_down was scaled with havengetallen before, but not anymore to avoid issues with aggers
     """
-    # early escape # TODO: consider not calling function in this case
+    # early escape # TODO: should also be possible to only scale tP_goal
     if HW_goal is None and LW_goal is None:
         return ts
 

diff --git a/tests/test_slotgemiddelden.py b/tests/test_slotgemiddelden.py
@@ -131,7 +131,7 @@ def test_calc_slotgemiddelden_with_gap(df_meas_2010_2014):
     slotgemiddelden_dict_withgap = kw.calc_slotgemiddelden(df_meas=df_meas_withgap, df_ext=None, min_coverage=1)
     slotgemiddelden_dict_withgap_lower_threshold = kw.calc_slotgemiddelden(df_meas=df_meas_withgap, df_ext=None, min_coverage=0.95)
 
-    # TODO: value to be updated, but should contain at least one nan value
+    # check if too large gap results in nan
     assert slotgemiddelden_dict_nogap["wl_mean_peryear"].isnull().sum() == 0
     assert slotgemiddelden_dict_withgap["wl_mean_peryear"].isnull().sum() == 1
     assert slotgemiddelden_dict_withgap_lower_threshold["wl_mean_peryear"].isnull().sum() == 0
diff --git a/tests/test_tidalindicators.py b/tests/test_tidalindicators.py
@@ -53,7 +53,7 @@ def test_calc_wltidalindicators_mincount(df_meas_2010_2014):
     slotgemiddelden_dict_withgap = kw.calc_wltidalindicators(df_meas_withgap, min_coverage=1)
     slotgemiddelden_dict_withgap_lower_threshold = kw.calc_wltidalindicators(df_meas_withgap, min_coverage=0.95)
 
-    # TODO: value to be updated, but should contain at least one nan value
+    # check if too large gap results in nan
     assert slotgemiddelden_dict_nogap["wl_mean_peryear"].isnull().sum() == 0
     assert slotgemiddelden_dict_withgap["wl_mean_peryear"].isnull().sum() == 1
     assert slotgemiddelden_dict_withgap_lower_threshold["wl_mean_peryear"].isnull().sum() == 0