feat(adapters):update to latest delft fiat release dod #666
Conversation
…into 651-update-to-latest-delft-fiat-release-dod
Santonia27
changed the title
Santonia27
changed the title
| @@ -91,6 +100,34 @@ def __init__( | |||
| self.config_base_path = config_base_path | |||
| self.exe_path = exe_path | |||
| self.delete_crashed_runs = delete_crashed_runs | |||
| self.fiat_columns_dict = { | |||
There was a problem hiding this comment.
why is this needed? You redefine all the names bellow in the fiat_output_mapping dictionary, right?
There was a problem hiding this comment.
because I only need the output mapping for the metrics after calculating the metrics.
Beforehand to actually do the calculation I used the self,fiat_columns_dict
flood_adapt/adapter/fiat_adapter.py
Outdated
| column=config["column"], | ||
|
|
||
| metrics_exposure = self.add_exceedance_probability( | ||
| column=FiatColumns.inundation_depth, |
There was a problem hiding this comment.
this is not always the inundation depth. It is provided in the config and could be the total damage for example. So probably the mapping dictionary should be used here as well?
flood_adapt/adapter/fiat_adapter.py
Outdated
| self.add_exceedance_probability( | ||
| column=config["column"], | ||
|
|
||
| metrics_exposure = self.add_exceedance_probability( |
There was a problem hiding this comment.
why is this called metrics exposure? It is the output table per object right?
There was a problem hiding this comment.
hmmm because it's the exposure data but for the output metrics.
maybe mapped_exposure_df?
There was a problem hiding this comment.
I think in the test it would be nice to use the class from the Fiat Adapter when calling column names
…into 651-update-to-latest-delft-fiat-release-dod
No description provided.