This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Switch to pnpm #508
Merged
Switch to pnpm #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
approved these changes
Jun 26, 2024
|
|
||
| - name: Build zip | ||
| run: npm run bundle | ||
| - name: Check bundle |
There was a problem hiding this comment.
I'm guessing this isn't related to the pnpm check? Seems like we just weren't doing it on deploy before?
There was a problem hiding this comment.
Yes, correct; an oversight in my last PR to bundle instead of uploading node_modules.
| - run: pnpm install | ||
| - run: pnpm run build | ||
| - run: pnpm test | ||
| - run: pnpm run bundle |
There was a problem hiding this comment.
Why do we have to bundle now when we didn't before?
There was a problem hiding this comment.
This was also an oversight in my last PR; we used to in this check test the compiled code, but that doesn't really matter, we want to verify that the bundle we're going to send to Azure even runs, just as an extra safety check.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In prep for moving to dt-tools; this should now be safe now that we bundle before uploading to Azure Functions.