This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Ignore draft PRs outside of the project board #353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the bot does to draft PRs is remove them from the project board, just like closed PRs:
dt-mergebot/src/pr-info.ts
Lines 188 to 189 in 251e2ba
So the daily script can ignore draft PRs that are already removed from the project board? Handle any exceptions in the
--cleanup
section, just like closed PRs. Eliminates some unnecessary work by the script and makes the closed/draft cases consistent.Adding
isDraft
to the all-open-prs query excludes draft PRs from the mainrun.ts
section. It includes them in the--cleanup
section because that checks!cardIDs.includes()
, which will now be true:dt-mergebot/src/run.ts
Line 125 in 251e2ba