Apply suggestions from code review

Co-authored-by: Eli Barzilay <[email protected]>
DefinitelyTyped · Nov 27, 2020 · 7de8392 · 7de8392
1 parent 87a49f7
commit 7de8392
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/src/compute-pr-actions.ts b/src/compute-pr-actions.ts
@@ -309,13 +309,8 @@ export function process(prInfo: PrInfo | BotEnsureRemovedFromProject | BotNoPack
     post({ tag: "welcome", status: createWelcomeComment(info) });
 
     // Propagate suggestions into actions
-    for (const pkg of info.pkgInfo) {
-        for (const file of pkg.files) {
-            if (file.suggestion) {
-                context.suggestions[file.path] = file.suggestion;
-            }
-        }
-    }
+    info.pkgInfo.forEach(pkg => pkg.files.forEach(file =>
+        file.suggestion && context.suggestions[file.path] = file.suggestion));
 
     // Ping reviewers when needed
     if (!(info.hasChangereqs || info.approvedBy.includes("owner") || info.approvedBy.includes("maintainer"))) {