Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(snowflake-sdk): Add noProxy connection option #69538

Merged
merged 2 commits into from May 18, 2024

Conversation

mikhuang
Copy link
Contributor

@mikhuang mikhuang commented May 6, 2024

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board May 6, 2024
@mikhuang mikhuang changed the title Update snowflake-sdk/index.d.ts update(snowflake-sdk): Add noProxy connection option May 6, 2024
@mikhuang mikhuang marked this pull request as ready for review May 6, 2024 23:38
@typescript-bot
Copy link
Contributor

typescript-bot commented May 6, 2024

@mikhuang Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69538,
  "author": "mikhuang",
  "headCommitOid": "913abd3848d8b74b86a0df25414c5a8feed9609d",
  "mergeBaseOid": "e1c40c9000e7c477c0c571bd4e07b5230cea067c",
  "lastPushDate": "2024-05-06T21:34:03.000Z",
  "lastActivityDate": "2024-05-18T04:49:14.000Z",
  "mergeOfferDate": "2024-05-18T01:53:01.000Z",
  "mergeRequestDate": "2024-05-18T04:49:14.000Z",
  "mergeRequestUser": "mikhuang",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "snowflake-sdk",
      "kind": "edit",
      "files": [
        {
          "path": "types/snowflake-sdk/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/snowflake-sdk/snowflake-sdk-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "htunnicliff",
        "orellabac",
        "boatilus",
        "briangottfried"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "boatilus",
      "date": "2024-05-18T01:52:24.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2097099911,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label May 6, 2024
@typescript-bot
Copy link
Contributor

🔔 @htunnicliff @orellabac @boatilus @briangottfried — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board May 6, 2024
@typescript-bot
Copy link
Contributor

Re-ping @htunnicliff, @orellabac, @boatilus, @briangottfried:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label May 18, 2024
Copy link
Contributor

@boatilus boatilus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels May 18, 2024
@typescript-bot
Copy link
Contributor

@mikhuang: Everything looks good here. I am ready to merge this PR (at 913abd3) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@htunnicliff, @orellabac, @boatilus, @briangottfried: you can do this too.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board May 18, 2024
@mikhuang
Copy link
Contributor Author

mikhuang commented May 18, 2024 via email

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 18, 2024
@typescript-bot typescript-bot merged commit acac6a1 into DefinitelyTyped:master May 18, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants