[color-hash] Types for version 2.0 #69536
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
pnpm test <package to test>
.Select one of these and delete the others:
If changing an existing definition:
package.json
.Version 2.0 released 2 years ago, the library was rewritten to typescript, however it does not come bundled with a .d.ts file. There is an issue open for this: zenozeng/color-hash#38, however the author has not responded to it. The changes I'm making are:
'bkdr'
as a valid hash function (https://github.com/zenozeng/color-hash/blob/5f717328a019f94bded34b88028105a7f467653d/mod.ts#L46),I am not sure about the
export =
vsexport default
situation here - the source code usesexport default ColorHash
, but the distributed package usesexports["default"] = ColorHash
. I hope this is correct.