Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[color-hash] Types for version 2.0 #69536

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Akatroj
Copy link

@Akatroj Akatroj commented May 6, 2024

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

Version 2.0 released 2 years ago, the library was rewritten to typescript, however it does not come bundled with a .d.ts file. There is an issue open for this: zenozeng/color-hash#38, however the author has not responded to it. The changes I'm making are:

I am not sure about the export = vs export default situation here - the source code uses export default ColorHash, but the distributed package uses exports["default"] = ColorHash. I hope this is correct.

@typescript-bot
Copy link
Contributor

typescript-bot commented May 6, 2024

@Akatroj Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 21 days — it is still unreviewed!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69536,
  "author": "Akatroj",
  "headCommitOid": "5b538b8ea1786a16f85bab5dfc7cede29563c898",
  "mergeBaseOid": "ce432dd83521beac5e46b4e82cdc1d86d963518a",
  "lastPushDate": "2024-05-06T16:34:29.000Z",
  "lastActivityDate": "2024-05-06T16:34:29.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "color-hash",
      "kind": "edit",
      "files": [
        {
          "path": "types/color-hash/color-hash-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/color-hash/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/color-hash/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "JohannesHoppe",
        "ksocha"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2096454083,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label May 6, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 6, 2024
@typescript-bot
Copy link
Contributor

🔔 @JohannesHoppe @ksocha — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Contributor

Re-ping @JohannesHoppe, @ksocha:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label May 17, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board May 24, 2024
@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @Akatroj.

(Ping @JohannesHoppe, @ksocha.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Popular package This PR affects a popular package (as counted by NPM download counts). Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer.
Projects
New Pull Request Status Board
Needs Maintainer Action
Development

Successfully merging this pull request may close these issues.

None yet

2 participants