Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lodash] fix _.has not to be inferred to never on or operator #69534

Merged

Conversation

Ha-limLee
Copy link
Contributor

fixed #69528

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented May 6, 2024

@Ha-limLee Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69534,
  "author": "Ha-limLee",
  "headCommitOid": "214ee2d29de300e73e8baa1653ffcfe0ef82252c",
  "mergeBaseOid": "20f1d855d85510c51368984655e4133d520301a2",
  "lastPushDate": "2024-05-06T14:06:50.000Z",
  "lastActivityDate": "2024-05-17T01:51:39.000Z",
  "mergeOfferDate": "2024-05-16T14:05:55.000Z",
  "mergeRequestDate": "2024-05-17T01:51:39.000Z",
  "mergeRequestUser": "Ha-limLee",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "lodash",
      "kind": "edit",
      "files": [
        {
          "path": "types/lodash/common/common.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/lodash/common/object.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/lodash/lodash-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "bczengel",
        "chrootsu",
        "aj-r",
        "e-cloud",
        "thorn0",
        "jtmthf",
        "DomiR",
        "WilliamChelman"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sandersn",
      "date": "2024-05-16T14:05:18.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "aj-r",
      "date": "2024-05-13T10:39:53.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2096108619,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @bczengel @chrootsu @aj-r @e-cloud @thorn0 @jtmthf @DomiR @WilliamChelman — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 6, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 6, 2024
@@ -1327,7 +1328,7 @@ declare module "../index" {
* _.has(other, 'a');
* // => false
*/
has<T, K extends PropertyName>(object: T, path: K): object is T & { [P in K]: P extends keyof T ? T[P] : Record<string, unknown> extends T ? T[keyof T] : unknown};
has<T, K extends PropertyName>(object: T, path: K): object is T & {[uniqueSymbol]: unknown} & { [P in K]: P extends keyof T ? T[P] : Record<string, unknown> extends T ? T[keyof T] : unknown};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: move & {[uniqueSymbol]: unknown} to the end of the line since it's the least important part.

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label May 12, 2024
@typescript-bot typescript-bot removed the Owner Approved A listed owner of this package signed off on the pull request. label May 13, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board May 13, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 13, 2024
@typescript-bot
Copy link
Contributor

@aj-r Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label May 13, 2024
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels May 16, 2024
@typescript-bot
Copy link
Contributor

@Ha-limLee: Everything looks good here. I am ready to merge this PR (at 214ee2d) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@bczengel, @chrootsu, @aj-r, @e-cloud, @thorn0, @jtmthf, @DomiR, @WilliamChelman: you can do this too.)

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board May 16, 2024
@Ha-limLee
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 17, 2024
@typescript-bot typescript-bot merged commit 4f7cc7d into DefinitelyTyped:master May 17, 2024
7 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version 4.17.1,the type of the data variable is inferred to never by _.has
4 participants