Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing class IllegalOperationError in amqplib #69531

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NinjaKinshasa
Copy link

Please fill in this template.

@typescript-bot
Copy link
Contributor

typescript-bot commented May 6, 2024

@NinjaKinshasa Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 12 days — please try to get reviewers!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69531,
  "author": "NinjaKinshasa",
  "headCommitOid": "6aea29333ba5792d31fcdf69ad4d5d89af17dd6c",
  "mergeBaseOid": "20f1d855d85510c51368984655e4133d520301a2",
  "lastPushDate": "2024-05-06T13:07:44.000Z",
  "lastActivityDate": "2024-05-18T07:52:39.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "amqplib",
      "kind": "edit",
      "files": [
        {
          "path": "types/amqplib/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "mnahkies",
        "abreits",
        "nfantone",
        "nickzelei",
        "XVincentX",
        "seonggwonyoon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "mnahkies",
      "date": "2024-05-17T19:33:23.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2095981406,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels May 6, 2024
@typescript-bot
Copy link
Contributor

Hey @NinjaKinshasa,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 6, 2024
@typescript-bot
Copy link
Contributor

🔔 @mnahkies @abreits @nfantone @nickzelei @XVincentX @seonggwonyoon — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 6, 2024
@typescript-bot
Copy link
Contributor

typescript-bot commented May 17, 2024

Re-ping @abreits, @nfantone, @nickzelei, @XVincentX, @seonggwonyoon:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label May 17, 2024
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label May 17, 2024
@typescript-bot
Copy link
Contributor

⏳ Hi @NinjaKinshasa,

It's been a few days since this PR was approved by mnahkies and we're waiting for a DT maintainer to give a review.

If you would like to short-circuit this wait, you can edit some of the test files in the package which verify how the .d.ts files work. This would allow the PR to be merged by you or the DT module owners after a re-review.

@@ -100,3 +100,9 @@ export const credentials: {
};

export function connect(url: string | Options.Connect, socketOptions?: any): Promise<Connection>;

export class IllegalOperationError extends Error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see a new definition here - but where is it used?

@NinjaKinshasa
Copy link
Author

Hello everyone, sorry for late reply.
I am not familiar with open source. I know tests are missing but I don't really know what to test here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. Untested Change This PR does not touch tests
Projects
New Pull Request Status Board
Needs Maintainer Review
Development

Successfully merging this pull request may close these issues.

None yet

4 participants