Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/selectize] Add missing silent parameter #69499

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codershiba
Copy link
Contributor

@codershiba codershiba commented May 2, 2024

Fixes #69495
Fixes #69428

Please fill in this template.

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented May 2, 2024

@codershiba Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69499,
  "author": "codershiba",
  "headCommitOid": "ee27f013c03ff0ec89b7bd24c26f55a3928e71f0",
  "mergeBaseOid": "11ab9a78ca6b1bf454b895aa874ca3f4b203b198",
  "lastPushDate": "2024-05-02T11:45:23.000Z",
  "lastActivityDate": "2024-05-16T16:44:46.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "selectize",
      "kind": "edit",
      "files": [
        {
          "path": "types/selectize/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "adidahiya",
        "naBausch"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "sandersn",
      "date": "2024-05-16T16:44:46.000Z"
    }
  ],
  "mainBotCommentID": 2090301338,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels May 2, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 2, 2024
@typescript-bot
Copy link
Contributor

Hey @codershiba,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Contributor

🔔 @adidahiya @naBausch — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 2, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board May 2, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 2, 2024
@jakebailey
Copy link
Member

The DT package is at 0.12, but the upstream package is at 0.15. When was this parameter actually added?

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label May 13, 2024
@typescript-bot
Copy link
Contributor

Re-ping @adidahiya, @naBausch:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

Copy link
Contributor

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes so the bot knows the current status.

@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels May 16, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Needs Author Action in New Pull Request Status Board May 16, 2024
@typescript-bot
Copy link
Contributor

@codershiba One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Popular package This PR affects a popular package (as counted by NPM download counts). Revision needed This PR needs code changes before it can be merged. Untested Change This PR does not touch tests
Projects
Development

Successfully merging this pull request may close these issues.

[@types/selectize]: Missing parameter "silent" in methods clearOptions() and refreshItems()
4 participants