Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[htmlhint] Revert htmlhint definition #58179

Closed

Conversation

martin-badin
Copy link
Contributor

@martin-badin martin-badin commented Jan 14, 2022

Revert htmlhint definition based on this issue htmlhint/HTMLHint#633

After merging my PR htmlhint/HTMLHint#865 to fix the issue I remove the types from this repository

Please fill in this template.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 14, 2022

@martin-badin Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

1 package in this PR (and infra files)

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes when there are new packages added

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 58179,
  "author": "martin-badin",
  "headCommitOid": "87d48261fd090330d09c7865f0fd13bd5c2c9df5",
  "mergeBaseOid": "beb2318cc19659e91e88346021930068b24bd5f3",
  "lastPushDate": "2022-01-14T06:31:00.000Z",
  "lastActivityDate": "2022-01-14T20:57:37.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "notNeededPackages.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "htmlhint",
      "kind": "add",
      "files": [
        {
          "path": "types/htmlhint/htmlhint-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/htmlhint/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/htmlhint/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/htmlhint/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "alan-agius4"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1012811371,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Edits Infrastructure labels Jan 14, 2022
@typescript-bot
Copy link
Contributor

🔔 @martin-badin — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Jan 14, 2022
@DangerBotOSS
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

htmlhint (unpkg)

was missing the following properties:

  1. HTMLParser

Generated by 🚫 dangerJS against 87d4826

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Jan 14, 2022
@peterblazejewicz
Copy link
Member

can we do skip this? and use only newer version you're adding in #58181?

@martin-badin
Copy link
Contributor Author

can we do skip this? and use only newer version you're adding in #58181?

Yes. I agree with you. I will close this PR.

@typescript-bot typescript-bot removed this from Needs Maintainer Action in New Pull Request Status Board Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits Infrastructure New Definition This PR creates a new definition package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants