Enable StrictConcurrency=complete swift feature flag #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasikpark
force-pushed
the
strict-concurrency-complete
branch
2 times, most recently
from
8819bfd to
e80a10e
Compare
jasikpark
force-pushed
the
enable-swift-6-feature-flags
branch
3 times, most recently
from
3593e8b to
a1914aa
Compare
jasikpark
force-pushed
the
strict-concurrency-complete
branch
3 times, most recently
from
c0eb5df to
1af5c48
Compare
jasikpark
force-pushed
the
enable-swift-6-feature-flags
branch
3 times, most recently
from
4203038 to
a3c598b
Compare
<https://github.com/swiftlang/swift-evolution/blob/main/proposals/0337-support-incremental-migration-to-concurrency-checking.md> This causes several warnings. I'm going to start by trying to silence them by reflecting the current state of the project, rather than fixing them directly.
jasikpark
force-pushed
the
strict-concurrency-complete
branch
from
ecc372d to
a0024e4
Compare
jasikpark
commented
Feb 25, 2025
| private var eventSink: FlutterEventSink? | ||
| private var eventChannel: FlutterEventChannel | ||
| private var site: Site | ||
| private var notification: Any? | ||
| public var startFunc: (() -> Void)? | ||
| private var configFd: Int32? = nil |
There was a problem hiding this comment.
these are also formatting changes from SwiftFormat, I can pull them out, but they're small correct changes, so 🤷
…te into other isolation domains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main ethos of this PR is to add annotations that denote how we are holding things today, with the goal of moving to a more explicitly data-race free system in the future.
https://github.com/swiftlang/swift-evolution/blob/main/proposals/0337-support-incremental-migration-to-concurrency-checking.md
This causes several warnings. I'm going to start by trying to silence them by reflecting the current state of the project, rather than fixing them directly.
Following the ethos of the paragraph that retorts the heading:
Refs: