update metadata

Decurity · Aug 15, 2024 · 513e8fb · 513e8fb
1 parent 2e8d46d
commit 513e8fb
Showing 1 changed file with 17 additions and 4 deletions.
diff --git a/solidity/security/bad-transferFrom-access-control.sol b/solidity/security/bad-transferFrom-access-control.sol
@@ -1,12 +1,13 @@
 contract Test {
+
     function func1(address from, address to) public {
         // ruleid: bad-transferFrom-access-control
         usdc.transferFrom(from, to, amount);
     }
 
     function func2(address from, address to) public {
         // ok: bad-transferFrom-access-control
-        usdc.transferFrom(owner, random, amount);
+        usdc.transferFrom(owner, pool, amount);
     }
 
     function func3(address from, address to) public {
@@ -26,7 +27,7 @@ contract Test {
 
     function func6(address from, address to) external {
         // ok: bad-transferFrom-access-control
-        usdc.transferFrom(owner, random, amount);
+        usdc.transferFrom(owner, pool, amount);
     }
 
     function func7(address from, address to) external {
@@ -86,7 +87,7 @@ contract Test {
 
     function func12(address from, address to) public {
         // ok: bad-transferFrom-access-control
-        usdc.safeTransferFrom(owner, random, amount);
+        usdc.safeTransferFrom(owner, pool, amount);
     }
 
     function func13(address from, address to) public {
@@ -106,7 +107,7 @@ contract Test {
 
     function func16(address from, address to) external {
         // ok: bad-transferFrom-access-control
-        usdc.safeTransferFrom(owner, random, amount);
+        usdc.safeTransferFrom(owner, pool, amount);
     }
 
     function func17(address from, address to) external {
@@ -156,4 +157,16 @@ contract Test {
         usdc.safeTransferFrom(from, to, amount);
     }
 
+    function _func21(address from, address to) internal {
+        // internal never called
+        // ok: bad-transferFrom-access-control
+        usdc.safeTransferFrom(from, to, amount);
+        // ok: bad-transferFrom-access-control
+        usdc.transferFrom(from, to, amount);
+        // ok: bad-transferFrom-access-control
+        TransferHelper.safeTransferFrom(usdc, from, to, amount);
+        // ok: bad-transferFrom-access-control
+        TransferHelper.transferFrom(usdc, from, to, amount);
+    }
+
 }