Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-functional list handling of compiler flags #851

Merged
merged 1 commit into from
May 6, 2024
Merged

Remove non-functional list handling of compiler flags #851

merged 1 commit into from
May 6, 2024

Conversation

sbvoxel
Copy link
Contributor

@sbvoxel sbvoxel commented Apr 30, 2024

The list append operation is a no-op. The line right below it is already doing the intended work.

@Alanscut
Copy link
Collaborator

Alanscut commented May 6, 2024

This was introduced with commit 76e5296d0d05ceb3018a9901639e0e171b44a557
The supported_compiler_flags do look like redundant.

@Alanscut Alanscut merged commit 98f9eb0 into DaveGamble:master May 6, 2024
13 checks passed
@sbvoxel sbvoxel deleted the fix-cmake branch May 6, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbvoxel @Alanscut